Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor terminal display #7339

Merged
merged 48 commits into from
Apr 12, 2024
Merged

feat: refactor terminal display #7339

merged 48 commits into from
Apr 12, 2024

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Apr 4, 2024 •
edited
Loading

Tracking remaining todos here:

  • Add tests for display.js (was waiting for API to be stable enough)
  • Confirm timing file message is shown to users the same as previously
  • See if control chars can be stripped only from strings after util.format
  • Make forceLog respect silent
  • Fix cross platform snapshot tests
  • fix logs in arborist test

@wraithgar wraithgar mentioned this pull request Apr 4, 2024
Closed
@lukekarrys lukekarrys mentioned this pull request Apr 6, 2024
Closed
@H4ad
Copy link
Contributor

H4ad commented Apr 6, 2024

From what I saw, this will help the initialization like my refactoring for npmlog, and looks even faster by some ms.

One thing that I noticed you didn't call the set-blocking, this is needed to not truncate logs greater than 64Kb, but this dependency introduces 3~5ms of slowdown.

@lukekarrys lukekarrys changed the title wip: remove npmlog Refactor terminal display Apr 8, 2024
wraithgar
wraithgar reviewed Apr 10, 2024
View reviewed changes
lib/cli-entry.js Outdated Show resolved Hide resolved
wraithgar
wraithgar reviewed Apr 11, 2024
View reviewed changes
lib/npm.js Show resolved Hide resolved
wraithgar
wraithgar reviewed Apr 11, 2024
View reviewed changes
lib/utils/display.js Outdated Show resolved Hide resolved
wraithgar
wraithgar reviewed Apr 11, 2024
View reviewed changes
lib/utils/format.js Outdated Show resolved Hide resolved
wraithgar
wraithgar reviewed Apr 11, 2024
View reviewed changes
test/lib/npm.js Outdated Show resolved Hide resolved
lukekarrys
lukekarrys commented Apr 11, 2024
View reviewed changes
lib/npm.js Show resolved Hide resolved
@lukekarrys lukekarrys marked this pull request as ready for review April 12, 2024 00:29
@lukekarrys lukekarrys requested a review from a team as a code owner April 12, 2024 00:29
@lukekarrys
Even better replacements for config snapshots
ff8a663
@lukekarrys
Actually update snapshot files
475e626
@lukekarrys
Make symlink log match a string for windows
def5e77
@lukekarrys
Fix cache dir in config snapshots
87fd3df
@lukekarrys
Change how execPath is cleaned in snapshots
743b0d0
@lukekarrys
Update smoke test snapshots for whitespace
fb9d47a
@lukekarrys
Refactor config snapshot cleaning for ini comments
983f8a5
@lukekarrys
Revert arborist shrinkwrap changes but add a comment warning to not d…
896c12e 
…o it again in the future
@lukekarrys
Revert leftover console.log
c645c1f
@lukekarrys
Remove npmlog from arborist and libnpmexec
de7b362
@lukekarrys
Run dependencies script
64164f5
@lukekarrys
use inline setBlocking function for display
1b5e75b
@lukekarrys
Update config snapshots again
93a68a6
@lukekarrys
Revert changed check in arborist tracker condition
3a0de03
@lukekarrys
Only output and log unix newlines
1e46f0c 
The formatter will properly convert for logfiles
wraithgar
wraithgar approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed this while still in draft mode, and reviewed changes as we went.

I also triple checked that we really do only need to strip C0 and C1 from strings now.

@lukekarrys lukekarrys merged commit 9622597 into latest Apr 12, 2024
81 checks passed
@lukekarrys lukekarrys deleted the lk/remove-npmlog branch April 12, 2024 20:48
@github-actions github-actions bot mentioned this pull request Apr 12, 2024
Merged
@H4ad
Copy link
Contributor

H4ad commented Apr 12, 2024

With this PR merged:

$ hyperfine --warmup 3 "./bin/npm-cli.js run empty" "~/.asdf/installs/nodejs/21.6.2/bin/node ./bin/npm-cli.js run empty"
Benchmark 1: ./bin/npm-cli.js run empty
  Time (mean ± σ):     155.1 ms ±   1.3 ms    [User: 141.4 ms, System: 46.0 ms]
  Range (min … max):   152.1 ms … 157.0 ms    19 runs
 
Benchmark 2: ~/.asdf/installs/nodejs/21.6.2/bin/node ./bin/npm-cli.js run empty
  Time (mean ± σ):      77.2 ms ±   0.7 ms    [User: 71.0 ms, System: 17.8 ms]
  Range (min … max):    75.8 ms …  79.2 ms    38 runs
 
Summary
  '~/.asdf/installs/nodejs/21.6.2/bin/node ./bin/npm-cli.js run empty' ran
    2.01 ± 0.03 times faster than './bin/npm-cli.js run empty'

Great work!

This was referenced Apr 25, 2024
Closed
Merged
ljharb referenced this pull request in ljharb/aud May 22, 2024
@ljharb
[Tests] npm v10.6.0 changed its error prefix from ERR! to error
af8b7f9
@mbtools mbtools mentioned this pull request Oct 21, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukekarrys @H4ad @wraithgar